Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: divorce driver version from libs version #2086

Merged
merged 11 commits into from
Jun 23, 2022
Merged

build: divorce driver version from libs version #2086

merged 11 commits into from
Jun 23, 2022

Conversation

leogr
Copy link
Member

@leogr leogr commented Jun 22, 2022 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind design

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

What this PR does / why we need it:

This PR allows using different versions of libs and driver.
Versions can be set respectively using the following cmake vars:

  • FALCOSECURITY_LIBS_VERSION
  • DRIVER_VERSION

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This is required to make Falco work with the new libs and drivers versioning system work.
We expect to git-tag those versions soon.

/milestone 0.32.1

Still a WIP since it Requires 👇
falcosecurity/libs#423

Does this PR introduce a user-facing change?:

build: introduce `DRIVER_VERSION` that allows setting a driver version (which may differ from the falcosecurity/libs version)
update: add more info to `--version` output

@poiana poiana added this to the 0.32.1 milestone Jun 22, 2022
leogr added 4 commits June 23, 2022 10:47
@leogr
chore(cmake/modules): indentation
c017d03 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
chore(cmake/modules): duplicate git history (part 1)
e6bca17 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
chore(cmake/modules): duplicate git history (part 2)
6cd1df9 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
build(cmake/modules): divorce driver from falcosecurity-libs module
95b3991 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the build/divorce-driver-version branch from 74e4fa1 to 32594c6 Compare June 23, 2022 08:48
@leogr leogr changed the title wip: build: divorce driver version from libs version build: divorce driver version from libs version Jun 23, 2022
leogr added 4 commits June 23, 2022 11:42
@leogr
build(cmake/modules): dedicated cmake module for the driver
6f00aa5 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
build: temporarily bump libs and driver
aa46181 
Note that another bump is required before releasing Falco, since this commit uses alpha versions.

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
update(userspace/falco): do not print driver version by default
c7ab085 
Since now each Falco version is compatible with a range of driver version and not just one.

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
update(userspace/falco): add more info to --version output
2a5c407 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the build/divorce-driver-version branch from f9495d3 to 2a5c407 Compare June 23, 2022 09:42
@leogr @FedeDP
chore(cmake/modules): remove leftover
09fd8c4 
Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
FedeDP
FedeDP previously approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very very very nice! Thanks Leo!
/approve

@poiana poiana added the lgtm label Jun 23, 2022
jasondellaluce
jasondellaluce reviewed Jun 23, 2022
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments Leo! This is awesome

cmake/modules/driver-repo/CMakeLists.txt Show resolved Hide resolved
userspace/falco/app_actions/print_version.cpp Outdated Show resolved Hide resolved
userspace/falco/app_actions/print_version.cpp Outdated Show resolved Hide resolved
@leogr @jasondellaluce
fix(userspace/falco/app_actions/print_version.cpp): ensure destructor…
fce934b 
… gets invoked


Signed-off-by: Leonardo Grasso <me@leonardograsso.com>

Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com>
@leogr @jasondellaluce
fix(userspace/falco/app_actions/print_version.cpp): correct getter ca…
cfaa34a 
…ll for schema version


Signed-off-by: Leonardo Grasso <me@leonardograsso.com>

Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com>
@leogr
Copy link
Member Author

leogr commented Jun 23, 2022

Close and reopen to update tide
/close

@poiana poiana closed this Jun 23, 2022
@poiana
Copy link
Contributor

poiana commented Jun 23, 2022

@leogr: Closed this PR.

In response to this:

Close and reopen to update tide
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member Author

leogr commented Jun 23, 2022

/reopen

@poiana poiana reopened this Jun 23, 2022
@poiana
Copy link
Contributor

poiana commented Jun 23, 2022

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jasondellaluce
jasondellaluce approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

🥳

FedeDP
FedeDP approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 2f208b5 into master Jun 23, 2022
@poiana poiana deleted the build/divorce-driver-version branch June 23, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@FedeDP FedeDP FedeDP approved these changes

@krisnova krisnova Awaiting requested review from krisnova

Assignees

@FedeDP FedeDP

@jasondellaluce jasondellaluce

Labels
approved area/build dco-signoff: yes kind/cleanup kind/design lgtm release-note size/L
Projects
None yet
Milestone
0.32.1
Development

Successfully merging this pull request may close these issues.
4 participants
@leogr @poiana @FedeDP @jasondellaluce